1 files changed, 150 insertions, 4 deletions

diff --git a/src/main_gui.cpp b/src/main_gui.cpp
index a561174..2e4eb91 100644
--- a/src/main_gui.cpp
+++ b/src/main_gui.cpp
@@ -111,6 +111,8 @@ static void PrintUsage()
     printf("  /help, -help, --help, /?\n");
     printf("  /datadir=PATH\n");
     printf("  /debug\n");
+    printf("  /debugrelay                (/debug plus per-message relay chatter and block dumps)\n");
+    printf("  /maxdebugfilesize=N        (roll debug.log at N MB, default 1024; 0 = never)\n");
     printf("  /gen\n");
     printf("  /nogui or /daemon\n");
     printf("  /selftest=wallet-keypool, wallet-hd, wallet-format, wallet-storage-sanity,\n");
@@ -123,6 +125,9 @@ static void PrintUsage()
     printf("Mining mode:\n");
     printf("  /operator\n");
     printf("  /participant=POOL_BTF_ADDRESS\n");
+    printf("  /payoutaddr=BTF_ADDRESS  (participant: pay shares to this address, no wallet needed)\n");
+    printf("  /payoutfile=FILE         (participant: rotate payout addresses from file)\n");
+    printf("  /hashthreads=N           (participant: mining threads, default cores-1)\n");
     printf("  /stratumbridge=POOL_BTF_ADDRESS\n");
     printf("  /stratumbridgeport=N       (default 3333; listen on 127.0.0.1)\n");
     printf("  /solomine\n");
@@ -150,6 +155,7 @@ static void PrintUsage()
     printf("  /socks=HOST:PORT           (SOCKS5 proxy for Nostr, .btf relay, and onion dials)\n");
     printf("  /tor[=HOST:PORT]           (Tor mode; default SOCKS5 proxy is 127.0.0.1:9050)\n");
     printf("  /managedtor[=PATH]         (start Tor, create a hidden service, advertise its onion)\n");
+    printf("  /automanagedtor            (auto-start a bundled Tor if one sits next to the executable)\n");
     printf("  /nomanagedtor              (disable automatic bundled Tor startup)\n");
     printf("  /oniononly                 (do not fall back to rendezvous when a .btf onion dial fails)\n");
     printf("  /btfseed=ADDRESS:ENCHEX    (extra bootstrap peer, repeatable)\n");
@@ -195,6 +201,9 @@ static void PrintUsage()
     printf("  /walletsqlite=FILE         (stage-load a SQLite wallet export, then exit)\n");
     printf("  /walletbackend=sqlite      (opt-in: run the node on <datadir>/wallet.sqlite\n");
     printf("                              instead of wallet.dat; export one first)\n");
+    printf("  /createwallet              (headless only: permit creating a new wallet in a\n");
+    printf("                              datadir that has none -- otherwise refused, since\n");
+    printf("                              a missing wallet is usually a mount/backup fault)\n");
     printf("  /rescan                    (walk the chain for coins this wallet owns\n");
     printf("                              but never recorded, then exit)\n");
     printf("\n");
@@ -214,6 +223,54 @@ static void ParseStartupArguments(int argc, char* argv[])
     if (arg(argc,argv,"/debug") || arg(argc,argv,"-debug"))
         fDebug = true;
 
+    // /debugrelay -- everything /debug shows, plus the per-message firehose
+    // ("relay" and "nostrdiscovery" categories: sending: tx, Relaying wtx,
+    // raw CBlock dumps, per-peer discovery lines). That traffic was ~90% of
+    // a 13-hour production debug.log (issue #35), so plain /debug leaves it
+    // off; the message text itself is unchanged for anyone grepping it.
+    if (arg(argc,argv,"/debugrelay") || arg(argc,argv,"-debugrelay"))
+    {
+        fDebug = true;
+        fDebugRelay = true;
+    }
+
+    // /maxdebugfilesize=N -- roll debug.log to debug.log.old once it passes
+    // N MB, checked on each write. Default is 1024 (see util.cpp); 0 turns
+    // the check off and leaves rotation entirely to logrotate.
+    string strMaxDebugSize = argval2(argc, argv, "/maxdebugfilesize", "-maxdebugfilesize");
+    if (!strMaxDebugSize.empty())
+    {
+        // Parsed with atoi64() before, which is strtoll() with the endptr
+        // thrown away: it returns 0 for anything it cannot read, so
+        // /maxdebugfilesize=1G and =1024MB both came out as 0 -- "never
+        // roll", identical to asking for that on purpose, with nothing said
+        // to the operator. The old code also multiplied without a range
+        // check, so a big enough N wrapped to a negative cap, which the roll
+        // reads as "off" too. Every rejection is now reported and leaves the
+        // default in place; the value is a plain count of MB, no suffix.
+        const char* psz = strMaxDebugSize.c_str();
+        char* pszEnd = NULL;
+        errno = 0;
+        int64 nMB = strtoll(psz, &pszEnd, 10);
+        // INT64_MAX, without depending on which limits header this tree pulls in.
+        const int64 nMaxMB = (int64)((~(uint64)0) >> 1) / (1024 * 1024);
+        const char* pszWhy = NULL;
+        if (pszEnd == psz)
+            pszWhy = "not a number";
+        else if (*pszEnd != '\0')
+            pszWhy = "trailing characters -- the value is a count of MB, with no unit suffix";
+        else if (errno == ERANGE || nMB < 0)
+            pszWhy = "not a size in MB";
+        else if (nMB > nMaxMB)
+            pszWhy = "larger than a file size can be";
+        if (pszWhy)
+            fprintf(stderr, "Ignoring /maxdebugfilesize=%s: %s (keeping %lld MB)\n",
+                    strMaxDebugSize.c_str(), pszWhy,
+                    (long long)(nMaxDebugFileSize / 1024 / 1024));
+        else
+            nMaxDebugFileSize = nMB * 1024 * 1024;
+    }
+
     if (arg(argc,argv,"/gen") || arg(argc,argv,"-gen"))
     {
         fGenerateBitcoins = 1;
@@ -245,7 +302,7 @@ static void ParseStartupArguments(int argc, char* argv[])
     if (!strProcLimit.empty())
     {
         int n = atoi(strProcLimit.c_str());
-        unsigned int nCores = std::thread::hardware_concurrency();
+        unsigned int nCores = AvailableCoreCount();
         if (n < 0)
             fprintf(stderr, "Ignoring /genproclimit=%s: not a thread count\n",
                     strProcLimit.c_str());
@@ -271,6 +328,18 @@ static void ParseStartupArguments(int argc, char* argv[])
         fMineModeFromCommandLine = true;
     }
 
+    string payoutAddr = argval2(argc, argv, "/payoutaddr", "-payoutaddr");
+    if (!payoutAddr.empty())
+        strPayoutAddress = payoutAddr;
+
+    string payoutFile = argval2(argc, argv, "/payoutfile", "-payoutfile");
+    if (!payoutFile.empty())
+        strPayoutFile = payoutFile;
+
+    string hashThreads = argval2(argc, argv, "/hashthreads", "-hashthreads");
+    if (!hashThreads.empty())
+        nHashThreads = atoi(hashThreads.c_str());
+
     if (arg(argc,argv,"/stratumbridge") || arg(argc,argv,"-stratumbridge"))
     {
         fStratumBridge = true;
@@ -297,6 +366,12 @@ static void ParseStartupArguments(int argc, char* argv[])
     if (!poolDash.empty())
         strPoolDashboardUrl = poolDash;
 
+    if (arg(argc,argv,"/noannounce") || arg(argc,argv,"-noannounce"))
+        fPoolNoAnnounce = true;
+
+    if (arg(argc,argv,"/poolmineblind") || arg(argc,argv,"-poolmineblind"))
+        fPoolMineBlind = true;
+
     string poolFee = argval2(argc, argv, "/poolfee", "-poolfee");
     if (!poolFee.empty())
         dPoolFeePercent = atof(poolFee.c_str());
@@ -317,8 +392,20 @@ static void ParseStartupArguments(int argc, char* argv[])
     string rvRelay = argval2(argc, argv, "/rvrelay", "-rvrelay");
     if (!rvRelay.empty())
     {
-        vBtfMeetingRelays.clear();
-        vBtfMeetingRelays.push_back(rvRelay);
+        if (!LooksLikeRelay(rvRelay))
+        {
+            // A malformed pin must not replace the seed list: with the pin
+            // set, no discovered relay can ever mask the typo, and the pool
+            // would publish a garbage (or no) meeting node forever.
+            fprintf(stderr, "Ignoring /rvrelay=%s: expected host:port\n",
+                    rvRelay.c_str());
+        }
+        else
+        {
+            vBtfMeetingRelays.clear();
+            vBtfMeetingRelays.push_back(rvRelay);
+            fBtfRelayPinned = true;
+        }
     }
 
     // net.cpp has described nListenPort as "tunable via /port" since it was
@@ -359,8 +446,16 @@ static void ParseStartupArguments(int argc, char* argv[])
     bool fTorMode = arg(argc, argv, "/tor") || arg(argc, argv, "-tor");
     string socksProxy = argval2(argc, argv, "/socks", "-socks");
     string bundledTorPath;
+    // Managed Tor is opt-in on this fork. Upstream 1.2.19 auto-starts a
+    // bundled tor whenever one sits next to the executable, which silently
+    // moves Nostr/.btf traffic onto Tor, creates a hidden service, and starts
+    // publishing descriptors with meeting_node="rendezvous-pending" on nodes
+    // that never asked for it -- against our pinned-relay posture. The
+    // upstream behavior remains available under the explicit /automanagedtor.
     bool fAutoManagedTor = !fManagedTor && !fNoManagedTor && !fTorMode &&
-                            socksProxy.empty() && BtfBundledTorPath(bundledTorPath);
+                            socksProxy.empty() &&
+                            (arg(argc, argv, "/automanagedtor") || arg(argc, argv, "-automanagedtor")) &&
+                            BtfBundledTorPath(bundledTorPath);
     if (fManagedTor || fAutoManagedTor)
     {
         if (fManagedTor && (fTorMode || !socksProxy.empty()))
@@ -804,6 +899,32 @@ int main(int argc, char* argv[])
                 else { fUseSQLite = true; fCreateSQLite = true; }
             }
 
+            // A headless node whose datadir holds no wallet of either kind is
+            // far more often an operations fault -- datadir not mounted, or
+            // wallet.dat caught mid-rename by a backup -- than a first run.
+            // Creating one here is not the harmless default it looks like:
+            // success also writes the backend marker, and from then on
+            // restoring the real wallet.dat no longer takes effect, because the
+            // marker keeps the node on the empty wallet it just made. Under
+            // 1.2.19 the same fault created a wallet.dat that a restore
+            // overwrote, so operators could recover by putting the file back.
+            // Refuse instead, and name the flag that makes it deliberate.
+            if (fCreateSQLite && fHeadlessStartup &&
+                !arg(argc, argv, "/createwallet") && !arg(argc, argv, "-createwallet"))
+            {
+                AttachTerminal();
+                fprintf(stderr,
+                        "No wallet found in %s\n"
+                        "Refusing to create one. On a headless node an absent wallet is\n"
+                        "usually a mount or backup fault, and creating one would record a\n"
+                        "backend marker that makes restoring the real wallet a no-op.\n"
+                        "Pass -createwallet to start a new one deliberately, or\n"
+                        "-walletbackend=bdb to run on a Berkeley DB wallet.dat.\n",
+                        GetAppDir().c_str());
+                fflush(stderr);
+                return 1;
+            }
+
             if (fUseSQLite)
             {
                 AttachTerminal();
@@ -1041,6 +1162,31 @@ int main(int argc, char* argv[])
 
     ReacceptWalletTransactions();
 
+    // /dumpaddresses=N:FILE -- generate N fresh wallet keys and write their
+    // addresses (one per line) to FILE, then exit. Keys stay in this wallet;
+    // the file alone is enough for a miner elsewhere to rotate payout
+    // addresses via /payoutfile. (No HD/xpub exists in this wallet format.)
+    string dumpSpec = argval2(argc, argv, "/dumpaddresses", "-dumpaddresses");
+    if (!dumpSpec.empty())
+    {
+        size_t colon = dumpSpec.rfind(':');
+        if (colon == string::npos) { fprintf(stderr, "usage: /dumpaddresses=N:FILE\n"); return 1; }
+        int n = atoi(dumpSpec.substr(0, colon).c_str());
+        string file = dumpSpec.substr(colon + 1);
+        FILE* f = fopen(file.c_str(), "w");
+        if (!f) { fprintf(stderr, "cannot open %s\n", file.c_str()); return 1; }
+        for (int i = 0; i < n; i++)
+        {
+            CKey key;
+            key.MakeNewKey();
+            if (!AddKey(key)) { fclose(f); fprintf(stderr, "AddKey failed at %d\n", i); return 1; }
+            fprintf(f, "%s\n", PubKeyToAddress(key.GetPubKey()).c_str());
+        }
+        fclose(f);
+        printf("wrote %d fresh wallet addresses to %s\n", n, file.c_str());
+        return 0;
+    }
+
     if (!StartNode(strErrors))
     {
         fprintf(stderr,"StartNode: %s\n",strErrors.c_str());