selftest: cover the payout ledger properties this series fixes

A new `payout-ledger` self-test, 40 assertions, wired into RunSelfTest and
into `make -C src tests`. It runs against a scratch data directory and an
in-memory wallet map: it never opens wallet.dat, never touches a real datadir,
and never sends anything.

What it asserts, defect by defect:

  - a restart does not duplicate an in-flight record. A matured round is
    exploded, the process state is thrown away and reloaded from the files
    twice, and the in-flight list must still hold exactly one record per
    recipient. Both guards are checked separately -- once with the round-level
    set restored, and once with it deliberately emptied so only the
    per-recipient check against gPaying can save it. A paying file already
    containing the duplicate the old build wrote must collapse on load, with
    the attempt counts merged upwards rather than reset.

  - state updates address a slot, not a value. Two records equal in every
    field -- exactly what the old code produced -- and rescheduling or
    forgetting one must land on the one it was given.

  - the ledger file cannot be published from a stale snapshot. An older
    snapshot published after a newer one must not appear on disk, and four
    threads publishing 64 large images of the same file in different orders
    must leave it parseable and equal to the highest version, whatever order
    they finish in.

  - a payment with only a legacy comment is recognised as already paid, and
    the fallback's limits hold: it requires the right recipient, the exact
    amount and the right height; one legacy transaction cannot settle a second
    debt; a transaction carrying another round's structured metadata is never
    accepted as legacy evidence; and the structured match still wins where it
    applies.

  - grandfathered zero-hash rounds do not answer for each other, both as a
    direct test of the round comparison and end to end -- recording a txid
    against one zero-hash round must leave the other still owed.

  - the retry clock that is actually used survives a restart.

  - a forfeit is published rather than silently dropped: the ledger loses that
    recipient and only that recipient, and the round proof records it with a
    reason instead of going on advertising the address as owed.

  - on-disk compatibility, checked against the real shapes: the live
    production pending_payouts.json (amounts / blockHash / blockHeight /
    matureAtHeight and nothing else), the merged build's shape including the
    retryAfter this build no longer writes, and a round trip through this
    build.

Each assertion was verified to fail when its defect is put back: seven
mutations were applied one at a time to a scratch copy and every one was
caught. Notably, re-introducing either half of the duplicate-record fix alone
is caught by its own assertion while the other half still prevents the
duplicate -- which is the defence in depth this series was asked for, checked
rather than asserted.

1 files changed, 4 insertions, 1 deletions

diff --git a/src/selftest.cpp b/src/selftest.cpp
index eed6779..034e1f7 100644
--- a/src/selftest.cpp
+++ b/src/selftest.cpp
@@ -13,6 +13,7 @@
 #include "walletcmd.h"
 
 extern int RunPoolStratumSelfTest();
+extern int RunPayoutLedgerSelfTest();
 
 // Test results go to the terminal, not to debug.log.
 //
@@ -1573,12 +1574,14 @@ int RunSelfTest(const std::string& name)
         return RunConsensusLimitsSelfTest();
     if (name == "pool-stratum")
         return RunPoolStratumSelfTest();
+    if (name == "payout-ledger")
+        return RunPayoutLedgerSelfTest();
     if (name == "parse-money")
         return RunParseMoneySelfTest();
     if (name == "socks5-proxy")
         return RunSocks5ProxySelfTest();
 
     printf("Unknown self-test '%s'\n", name.c_str());
-    printf("Known self-tests: wallet-keypool, wallet-hd, wallet-format, wallet-crypto, wallet-encrypt, net-message, consensus-limits, pool-stratum, parse-money, socks5-proxy\n");
+    printf("Known self-tests: wallet-keypool, wallet-hd, wallet-format, wallet-crypto, wallet-encrypt, net-message, consensus-limits, pool-stratum, payout-ledger, parse-money, socks5-proxy\n");
     return 1;
 }