Merge pull request 'wallet: install backups via temporary file' (#43) from wallet-backup-tempfile-install into main

1 files changed, 7 insertions, 0 deletions

diff --git a/src/selftest.cpp b/src/selftest.cpp
index 638aa66..81c4439 100644
--- a/src/selftest.cpp
+++ b/src/selftest.cpp
@@ -1391,6 +1391,13 @@ static int RunWalletPortabilitySelfTest()
         nFail += Check(nBackupRet == 0 && FileExists(strPortableWallet.c_str()),
                        "/backupwallet writes a portable wallet.dat") ? 0 : 1;
 
+        string strBackupOut2 = tmp + "/backupwallet-overwrite.txt";
+        int nBackupRet2 = RunBitflashChild(strExe, vBackupArgs, NULL, &strBackupOut2);
+        nFail += Check(nBackupRet2 == 0 && FileExists(strPortableWallet.c_str()) &&
+                       !DirectoryHasFileWithPrefix(tmp, "portable-wallet.dat.tmp.") &&
+                       !DirectoryHasFileWithPrefix(tmp, "portable-wallet.dat.old."),
+                       "/backupwallet replaces an existing backup without leaving temp files") ? 0 : 1;
+
         nFail += Check(CopyFileLocal(strOriginal + "/wallet.dat",
                                      strRawCopy + "/wallet.dat"),
                        "a raw wallet.dat can be copied without database logs") ? 0 : 1;