wallet encryption: the stack from #130–#133, with the two blockers fixed (#134)

* wallet: refuse future encrypted wallet formats

* wallet: add encrypted key unlock core

* wallet: add encryptwallet rewrite command

* wallet: read passphrases from stdin or files

* wallet: keep the derivation across encryption, and take the logs with it

Two things stopped the encryption stack from being safe to merge. Both
were found against a wallet holding real coin, not in the self-tests.

1. Encrypting turned a BIP44 wallet into a legacy one.

LoadWallet() ends by resetting the schema and the derivation counters
when no seed is in memory. That was written when "no seed after loading"
could only mean the wallet had none. An encrypted wallet has a seed --
it just has not been decrypted yet -- so the reset threw away metadata
that had been read correctly a moment earlier. Unlocking later restores
the seed and nothing restores the rest.

Measured on the wallet from the #124 proof: after encrypting, index 1
moved off BAtgSgra2X8Dqo5PJzPCLJhPwrrC2thYVJ, the address actually
holding 1.00 BTF, and the audit went from "1.00 covered by the phrase"
to "0.00 covered, 1.00 wallet.dat-only". Encrypt your wallet and the
program told you your recovery phrase no longer covered your money.

Now the condition also accepts a wallet whose seed is present but
encrypted. Same wallet, before and after: schema bip44, same four
derived addresses, 1.00 BTF still reported as covered.

2. The plaintext keys stayed behind in the Berkeley DB logs.

wallet.dat comes out clean -- verified by scanning the raw file for the
118 bytes of a known private key. database/log.0000000002 did not: it
held the whole key, and still did after a full node restart, because
every record this wallet ever wrote passed through the log.

That defeats the feature for the case it exists for, since our own
backup advice is to copy the whole directory rather than wallet.dat
alone. log_archive() cannot fix it: it only drops logs Berkeley DB
considers obsolete and never the one it is writing to, and with one 10
MB log per directory that is precisely where the keys are. They also did
not get there at encryption time -- they accumulated over the wallet's
whole life -- so nothing done during the rewrite can archive them out.

So the encrypt command now closes the environment and deletes the logs
on its way out, after the flush that makes every .dat self-contained.
This is not secure erasure; the blocks are unlinked, not overwritten.
It closes the case of someone reading a copied data directory.

Getting there uncovered a third bug, older than both.

DBFlush(true) is not safe to call twice. The first call closes the
environment, and txn_checkpoint() on a closed environment segfaults
instead of returning an error, so the try/catch around it never sees
anything. EncryptWallet() already flushes before renaming the wallet,
and the command flushes again on the way out -- that pair crashed every
single time. Guarded now.

The same function has been calling log_archive() with the address of an
uninitialised pointer since 0.1.0, on every clean shutdown, in a path
whose catch(...) cannot catch a structured fault on Windows.
DB_ARCH_REMOVE requires that argument to be NULL. Fixed while here,
because the encryption cleanup depends on that call not being a coin
flip.

---------

Co-authored-by: Gilcimar Duarte <ti@gpm.infra>

1 files changed, 50 insertions, 39 deletions

diff --git a/src/script.cpp b/src/script.cpp
index 6d4fb34..1e6e1ca 100644
--- a/src/script.cpp
+++ b/src/script.cpp
@@ -1020,43 +1020,54 @@ bool Solver(const CScript& scriptPubKey, uint256 hash, int nHashType, CScript& s
     if (!Solver(scriptPubKey, vSolution))
         return false;
 
-    // Compile solution
-    CRITICAL_BLOCK(cs_mapKeys)
+    // Compile solution. Public keys stay available for encrypted wallets so the
+    // wallet can recognize its own outputs while locked; private keys are
+    // fetched only for an actual signature.
+    foreach(PAIRTYPE(opcodetype, valtype)& item, vSolution)
     {
-        foreach(PAIRTYPE(opcodetype, valtype)& item, vSolution)
+        if (item.first == OP_PUBKEY)
         {
-            if (item.first == OP_PUBKEY)
+            const valtype& vchPubKey = item.second;
+            if (!WalletCanSpendKey(vchPubKey))
+                return false;
+            if (hash != 0)
             {
-                // Sign
-                const valtype& vchPubKey = item.second;
-                if (!mapKeys.count(vchPubKey))
+                CPrivKey vchPrivKey;
+                string strError;
+                if (!GetWalletPrivKey(vchPubKey, vchPrivKey, strError))
+                    return false;
+                vector<unsigned char> vchSig;
+                if (!CKey::Sign(vchPrivKey, hash, vchSig))
                     return false;
-                if (hash != 0)
+                vchSig.push_back((unsigned char)nHashType);
+                scriptSigRet << vchSig;
+            }
+        }
+        else if (item.first == OP_PUBKEYHASH)
+        {
+            vector<unsigned char> vchPubKey;
+            {
+                CRITICAL_BLOCK(cs_mapKeys)
                 {
-                    vector<unsigned char> vchSig;
-                    if (!CKey::Sign(mapKeys[vchPubKey], hash, vchSig))
+                    map<uint160, valtype>::iterator mi = mapPubKeys.find(uint160(item.second));
+                    if (mi == mapPubKeys.end())
                         return false;
-                    vchSig.push_back((unsigned char)nHashType);
-                    scriptSigRet << vchSig;
+                    vchPubKey = (*mi).second;
                 }
             }
-            else if (item.first == OP_PUBKEYHASH)
+            if (!WalletCanSpendKey(vchPubKey))
+                return false;
+            if (hash != 0)
             {
-                // Sign and give pubkey
-                map<uint160, valtype>::iterator mi = mapPubKeys.find(uint160(item.second));
-                if (mi == mapPubKeys.end())
+                CPrivKey vchPrivKey;
+                string strError;
+                if (!GetWalletPrivKey(vchPubKey, vchPrivKey, strError))
                     return false;
-                const vector<unsigned char>& vchPubKey = (*mi).second;
-                if (!mapKeys.count(vchPubKey))
+                vector<unsigned char> vchSig;
+                if (!CKey::Sign(vchPrivKey, hash, vchSig))
                     return false;
-                if (hash != 0)
-                {
-                    vector<unsigned char> vchSig;
-                    if (!CKey::Sign(mapKeys[vchPubKey], hash, vchSig))
-                        return false;
-                    vchSig.push_back((unsigned char)nHashType);
-                    scriptSigRet << vchSig << vchPubKey;
-                }
+                vchSig.push_back((unsigned char)nHashType);
+                scriptSigRet << vchSig << vchPubKey;
             }
         }
     }
@@ -1080,27 +1091,27 @@ bool ExtractPubKey(const CScript& scriptPubKey, bool fMineOnly, vector<unsigned
     if (!Solver(scriptPubKey, vSolution))
         return false;
 
-    CRITICAL_BLOCK(cs_mapKeys)
+    foreach(PAIRTYPE(opcodetype, valtype)& item, vSolution)
     {
-        foreach(PAIRTYPE(opcodetype, valtype)& item, vSolution)
+        valtype vchPubKey;
+        if (item.first == OP_PUBKEY)
         {
-            valtype vchPubKey;
-            if (item.first == OP_PUBKEY)
-            {
-                vchPubKey = item.second;
-            }
-            else if (item.first == OP_PUBKEYHASH)
+            vchPubKey = item.second;
+        }
+        else if (item.first == OP_PUBKEYHASH)
+        {
+            CRITICAL_BLOCK(cs_mapKeys)
             {
                 map<uint160, valtype>::iterator mi = mapPubKeys.find(uint160(item.second));
                 if (mi == mapPubKeys.end())
                     continue;
                 vchPubKey = (*mi).second;
             }
-            if (!fMineOnly || mapKeys.count(vchPubKey))
-            {
-                vchPubKeyRet = vchPubKey;
-                return true;
-            }
+        }
+        if (!fMineOnly || WalletCanSpendKey(vchPubKey))
+        {
+            vchPubKeyRet = vchPubKey;
+            return true;
         }
     }
     return false;