payout: drop a disjunct in the forfeit path that decides nothing

ForfeitPayoutRecipient retired an entry on
`it->amounts.empty() || PayoutFullyPaid(*it)`. PayoutFullyPaid iterates
amounts looking for a recipient with no txid, so it returns true for an
empty map: the first test can only be true where the second already is.

Left in, it reads as though the two cases differ, which invites someone
to make them differ. The condition is unchanged; only the claim about it
is.

Property: unchanged behaviour, and the code now says only what it does.

1 files changed, 4 insertions, 1 deletions

diff --git a/src/rpc.cpp b/src/rpc.cpp
index a9eca8a..7b45fea 100644
--- a/src/rpc.cpp
+++ b/src/rpc.cpp
@@ -1921,7 +1921,10 @@ static void ForfeitPayoutRecipient(const PayingRecord& r, const std::string& rea
                                  r.blockHeight, r.blockHash))
                 continue;
             it->amounts.erase(r.address);
-            if (it->amounts.empty() || PayoutFullyPaid(*it))
+            // PayoutFullyPaid() returns true for an empty amounts map -- there
+            // is no recipient in it without a txid -- so the
+            // `amounts.empty()` disjunct that used to be here decided nothing.
+            if (PayoutFullyPaid(*it))
                 gPendingPayouts.erase(it);
             break;
         }