diag: count sockets by where they were created, and whether the close took (#86)

A node was found holding 1502 sockets in Windows bound state, one ephemeral port
each, 9% of the machine range in nineteen hours. Reading the code did not find
it: every connect() failure path here closes its socket.

So count. Every socket is tagged at creation and untagged at close, across all
ten sites, with a counter for closes that fail. Already rules out three
explanations: nothing is created or closed behind the counter (untagged closes
are zero), no close is failing, and the leaked sockets are not in the live set --
tracked live matches what the OS reports as established, while the bound pile is
something the program already closed successfully.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/nostr.cpp b/src/nostr.cpp
index 17139ad..dc96be2 100644
--- a/src/nostr.cpp
+++ b/src/nostr.cpp
@@ -462,7 +462,7 @@ public:
     {
         if (ssl)    { SSL_shutdown(ssl); SSL_free(ssl); ssl = NULL; }
         if (sslctx) { SSL_CTX_free(sslctx); sslctx = NULL; }
-        if (hSocket != INVALID_SOCKET) { closesocket(hSocket); hSocket = INVALID_SOCKET; }
+        if (hSocket != INVALID_SOCKET) { BtfCloseSocket(hSocket); hSocket = INVALID_SOCKET; }
     }
 
     int RawRead(char* buf, int len)
@@ -518,7 +518,7 @@ public:
         bool fConnected = false;
         for (rp = res; rp != NULL; rp = rp->ai_next)
         {
-            hSocket = socket(rp->ai_family, rp->ai_socktype, rp->ai_protocol);
+            hSocket = BtfSocketTag(socket(rp->ai_family, rp->ai_socktype, rp->ai_protocol), SOCK_NOSTR);
             if (hSocket == INVALID_SOCKET)
                 continue;
 
@@ -542,7 +542,7 @@ public:
                 break;
             }
 
-            closesocket(hSocket);
+            BtfCloseSocket(hSocket);
             hSocket = INVALID_SOCKET;
         }
         freeaddrinfo(res);