rpc: the payout comment claims a guarantee the code does not provide (#22)

It reads:

  Save BEFORE moving to exec queue: if we crash between the save and
  SendMoney, LoadPendingPayouts re-queues them from the exec-queue
  section of the file.

There is no exec-queue section. SavePendingPayouts serialises
gPendingPayouts and nothing else, and a matured payout is erased from it
and written out before ever reaching the queue, which lives only in
memory. Crash in between and those miners are never paid, with no record
they were owed anything.

Only the comment changes here. The behaviour needs idempotent payment --
record the txid, look for it in the wallet on restart -- because simply
persisting the queue and re-running it would double-pay anyone already
sent to, which is the worse failure.

0 files changed, 0 insertions, 0 deletions